Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix CI Errors Involving gRPC and old versions of Go #313

Closed
RichVanderwal opened this issue May 11, 2021 · 1 comment · Fixed by #314
Closed

Fix CI Errors Involving gRPC and old versions of Go #313

RichVanderwal opened this issue May 11, 2021 · 1 comment · Fixed by #314
Assignees

Comments

@RichVanderwal
Copy link
Contributor

Something has happened to our CI testing so that older versions of Go can't use gRPC.

This quick one-liner will show that the latest gRPC module doesn't install properly into the official Go Docker images before Go version 1.13: for GOVERSION in `seq 7 16` ; do echo ====== GO VERSION 1.$GOVERSION ====== && docker run --rm -it golang:1.$GOVERSION bash -c "go get -u google.golang.org/grpc"; done

There is special logic in our build-script.sh to skip gRPC for 1.7 and 1.8, and we also do a special build for Go 1.9. Perhaps this is where we can fix this, after researching whether or not gRPC can run on earlier versions of Go anymore.

@RichVanderwal RichVanderwal self-assigned this May 11, 2021
@RichVanderwal RichVanderwal added this to the May Go Agent Release milestone May 11, 2021
@RichVanderwal RichVanderwal linked a pull request May 14, 2021 that will close this issue
@RichVanderwal
Copy link
Contributor Author

Fixed quite a few errors, but we still have four problem tests left:

  • 1.13.x, _integrations/nrawssdk
  • 1.15.x, v3/integrations/nrawssdk-v1, go get -u github.com/aws/aws-sdk-go@main
  • 1.15.x, v3/integrations/nrecho-v4, go get -u github.com/labstack/echo@master
  • 1.15.x, v3/integrations/nrgraphgophers, go get -u github.com/graph-gophers/graphql-...

It'll take another day or two to sort these out.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant