Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade mongodb driver to 1.5.1 to resolve security issue in external dependency. #358

Closed
RichVanderwal opened this issue Aug 3, 2021 · 0 comments · Fixed by #370 or #374
Closed
Assignees

Comments

@RichVanderwal
Copy link
Contributor

This should be a quick fix. However, there's one puzzling thing: this test passes in CI, but on my workstation fails with both 1.5.1 and 1.0.0, which is what the integration's go.mod file is set to use.

We should probably figure this out before committing this change.

√ ~/newrelic/go-agent/v3/integrations/nrmongo % go test ./...                                                                                                               14:21:54
# github.com/newrelic/go-agent/v3/integrations/nrmongo [github.com/newrelic/go-agent/v3/integrations/nrmongo.test]
./nrmongo_test.go:44:32: not enough arguments in call to sysinfo.Hostname
	have ()
	want (bool, []string)
./nrmongo_test.go:242:7: reply.SetSampleEverything undefined (type *internal.ConnectReply has no field or method SetSampleEverything)
FAIL	github.com/newrelic/go-agent/v3/integrations/nrmongo [build failed]
?   	github.com/newrelic/go-agent/v3/integrations/nrmongo/example	[no test files]
FAIL
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant