Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Release tarball contains composer temp file #1482

Closed
darix opened this issue Sep 15, 2024 · 4 comments · Fixed by #1499
Closed

Release tarball contains composer temp file #1482

darix opened this issue Sep 15, 2024 · 4 comments · Fixed by #1499
Labels
bug Something isn't working

Comments

@darix
Copy link

darix commented Sep 15, 2024 

vendor/composer/tmp-017861df0cfa7b0cdb83a3038d7a38e3~

not sure this really needs to be in the tarball.
@darix darix added the bug Something isn't working label Sep 15, 2024
@akhil1508
Copy link
Contributor

  • The issue is seen since v2.13.0
  • We tried reproducing locally but make build doesn't add the file to the built tar
    • So probably a build system related problem

@mejo- Could you check if this file exists on your environment?

@darix
Copy link
Author

darix commented Sep 19, 2024

i used the tarball referenced from https://apps.nextcloud.com/apps/collectives

@mejo- mejo- mentioned this issue Sep 23, 2024
Merged
@darix
Copy link
Author

darix commented Sep 23, 2024

will you roll a new release as well? :)

@max-nextcloud
Copy link
Collaborator

Yes. We have this scheduled for this week.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Makefile): Run distclean as dependency of release nextcloud/collectives
3 participants
@darix @akhil1508 @max-nextcloud