Upgrade to Collectives version 0.20.22 brakes my NC23 installation

[mejo-]

In GitLab by @fenvarien on Mar 3, 2022, 19:27

I have just updated to Nextcloud Collectives version 0.20.22. After this my Nextcloud is stuck in maintenance mode. If I disable the Collectives app with occ I can turn off the maintenance mode and my NC works flawlessly again.

Steps to reproduce: Upgrade Collectives from version 0.19.22 to version 0.20.22 with NC 23.0.2 --> NC is stuck in maintenance mode.

Workaround: Using occ to disable and remove Collectives app, then reinstall the current version with occ. After this workaround version 0.20.22 is working well.

I have Nextcloud version 23.0.2, PHP: 8.0.16, PostgreSQL 14.2

[mejo-]

In GitLab by @TheNomad11 on Mar 3, 2022, 21:10

Same here, the second time it happens with this app that it crashes the whole NC instance

[mejo-]

Thanks for your reports @fenvarien and @TheNomad11. Do you see any error logs related to the update of Collectives? We tested the upgrade on Nextcloud 22 and 23 and didn't spot any issues so far.

Are you both running Nextcloud with PostgreSQL? I have to admit that I didn' test an upgrade with PostgreSQL yes.

[mejo-]

In GitLab by @TheNomad11 on Mar 3, 2022, 22:45

Yee, it is PostgreSQL 14.2.
I use the AIO Docker version https://github.com/nextcloud/all-in-one

I found this in the logs

[index] Error: Undefined constant OCA\Collectives\Db\Collective::defaultPermissions in file '/var/www/html/custom_apps/collectives/lib/Migration/Version002000Date20220103000000.php' line 31

[mejo-]

mentioned in commit 3359db4

[mejo-]

Thanks for the quick response @TheNomad11! That was helpful. I'll upload version 0.21.22 with a fix right away. Might need a few hours to be available in the app store though.

[mejo-]

Collectives 0.21.22 with a fix is now published to the app store: https://apps.nextcloud.com/apps/collectives

It would be highly appreciated if you could test the upgrade and report back. Sorry for the inconveniences caused by this bug.

Some technical background: Apparently, when the migration step is run, it's not guaranteed that the app code is updated already. That's why OCA\Collectives\Db\Collective::defaultPermissions was not accessible during the migration step. Lesson learned.

[mejo-]

In GitLab by @mkrecek234 on Mar 4, 2022, 04:55

@mejo- I installed this most recent .22 version on my instance skipping the last days release and updating straight to .22.

Same issue now, my Nc23 is stuck in maintenance mode. How can I get it out of it? Please help asap if possible and fix Collectives ultimately. Thank you

[mejo-]

In GitLab by @baltaner on Mar 4, 2022, 08:49

Hi,
another problem occur since update to collectives 0.20.22:
I now get on overview-page (Security & setup warnings)
There are some errors regarding your setup. Some files have not passed the integrity check.

Any ideas?

Results

• core
  • INVALID_HASH
    • core/js/mimetypelist.js

Raw output

Array
(
[core] => Array
(
[INVALID_HASH] => Array
(
[core/js/mimetypelist.js] => Array
(
[expected] => 94195a260a005dac543c3f6aa504f1b28e0078297fe94a4f52f012c16c109f0323eecc9f767d6949f860dfe454625fcaf1dc56f87bb8350975d8f006bbbdf14a
[current] => 1b07fb272efa65a10011ed52a6e51260343c5de2a256e1ae49f180173e2b6684ccf90d1af3c19fa97c31d42914866db46e3216883ec0d6a82cec0ad5529e78b1

[mejo-]

Hey @mkrecek234, which Collectives version exactly did you upgrade to? 0.20.22 or 0.21.22?

You can turn of maintenance mode by running the command ./occ maintenance:mode --off inside your Nextcloud installation directory.

If you don't have console access to your Nextcloud installation, edit config/config.php and set 'maintenance' => false.

[mejo-]

Hey @baltaner,

this seems completely unrelated to the Collectives update. core/js/mimetypelist.js is provided by the Nextcloud server package, not by Collectives. Are you sure that the warning wasn't there before?

[mejo-]

In GitLab by @baltaner on Mar 4, 2022, 10:49

Hi @mejo-
thanks for your answer,
I'm not 100% sure - but two days ago everything was ok...

[mejo-]

In GitLab by @TheNomad11 on Mar 4, 2022, 11:02

Version 0.21.22 seems to work fine, although my monitoring service detected that NC went down for a few seconds during the upgrade. Nothing in the logs, everything seems to work as it should. Thanks for the quick fix!

[mejo-]

In GitLab by @mkrecek234 on Mar 4, 2022, 11:38

@mejo- PLEASE help. Even occ maintenance:mode --off confirms it is off, Nextcloud still shows maintenance mode screen. I even disabled the collectives app, but no difference

[mejo-]

They @mkrecek234, so occ maintenance:mode shows the maintenance mode as off already? Did you try restarting the webserver and/or your php-fpm service? Sometimes, that's necessary as well in my experience.

[mejo-]

In GitLab by @mkrecek234 on Mar 4, 2022, 15:18

@mejo- Thank you restarting fpm on top helped