Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Confusing search icon (needs to be replaced by a more suggestive one) #9942

Closed
Jerome-Herbinet opened this issue Jul 30, 2024 · 6 comments · Fixed by #10056
Closed

Confusing search icon (needs to be replaced by a more suggestive one) #9942

Jerome-Herbinet opened this issue Jul 30, 2024 · 6 comments · Fixed by #10056

Comments

@Jerome-Herbinet
Copy link
Member

Is your feature request related to a problem? Please describe.

In my opinion, the button below is confusing. The icon used suggests more a "settings" notion of the current application or account, or the current folder, but has nothing to do with the notion of search (or filter). Instinctively, when I look for a search or filter button in an interface, it looks like a magnifying glass or a funnel, but certainly not like the icon currently in use.
Capture d’écran du 2024-07-30 09-40-37

Describe the solution you'd like

We need an icon that really suggests the notion of search or filtering. Here's a test I've done with my browser's code inspector. I've replaced the tune icon with a magnifying glass icon directly suggesting the notion of search. It could also have been a funnel icon suggesting a notion of filtering.
I also modified the tooltip, thinking it would be clearer that way, but that's a detail compared to the icon problem. Depending on what the design team says, I may open a PR.
Capture d’écran du 2024-07-30 09-45-07

@nextcloud/designers

Describe alternatives you've considered

No response

Additional context

No response

@ChristophWurst
Copy link
Member

The icon was spec'ed at #6546 (comment).

@nimishavijay shall we replace the icon?

@marcoambrosini
Copy link
Member

I think a filter icon would be the most proper here
https://fonts.google.com/icons?selected=Material+Symbols+Outlined:filter_alt:FILL@1;wght@400;GRAD@0;opsz@24&icon.query=filter&icon.size=24&icon.color=%235f6368

@ChristophWurst
Copy link
Member

Let me know which icon to use and I'll change it. The filter icon was there before the settings icon: #6546 (comment).

@nimishavijay
Copy link
Member

Filter icon makes sense here. Originally the settings icon (MDI "tune" icon) was used for parity with Gmail, but you're right, Gmail's search flow is different (entirely new screen shows up with search results , so that button was used to "tune" the search). Over here since the current view is just being filtered it makes sense to use the filter icon 👍

@Jerome-Herbinet
Copy link
Member Author

I think a filter icon would be the most proper here https://fonts.google.com/icons?selected=Material+Symbols+Outlined:filter_alt:FILL@1;wght@400;GRAD@0;opsz@24&icon.query=filter&icon.size=24&icon.color=%235f6368

@marcoambrosini do we use Google icons set ? In any case can you tell me where to find the name of the icon to replace it in the source code ? (for the PR)

@nimishavijay nimishavijay moved this to 🏗️ At engineering in 🖍 Design team Aug 6, 2024
@jancborchardt
Copy link
Member

@marcoambrosini @nimishavijay I would say the "Filter List" icon is better and more symbolic than the "funnel" looking filter icon:
https://fonts.google.com/icons?selected=Material+Symbols+Outlined:filter_list:FILL@1;wght@400;GRAD@0;opsz@24&icon.query=filter&icon.size=24&icon.color=%235f6368

@Jerome-Herbinet it seems to be called "tune" or "tune-icon", that should help finding it in the code:
image

@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Sep 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants