refactor(nextcloud)!: Remove AppType and simplify user-agent configuration

Signed-off-by: provokateurin <kate@provokateurin.de>

Author: provokateurin

packages/neon_framework/lib/src/blocs/#_check_account.dart

@@ -59,7 +59,7 @@ class _LoginCheckAccountBloc extends InteractiveBloc implements LoginCheckAccoun
         serverURL,
         loginName: loginName,
         password: password,
-        userAgentOverride: neonUserAgent,
+        userAgent: neonUserAgent,
       );
 
       final response = await client.provisioningApi.users.getCurrentUser();

packages/neon_framework/lib/src/blocs/#_check_server_status.dart

@@ -50,7 +50,7 @@ class _LoginCheckServerStatusBloc extends InteractiveBloc implements LoginCheckS
     try {
       final client = NextcloudClient(
         serverURL,
-        userAgentOverride: neonUserAgent,
+        userAgent: neonUserAgent,
       );
 
       final status = await client.core.getStatus();

packages/neon_framework/lib/src/blocs/#_flow.dart

@@ -39,7 +39,7 @@ class _LoginFlowBloc extends InteractiveBloc implements LoginFlowBloc {
   final Uri serverURL;
   late final client = NextcloudClient(
     serverURL,
-    userAgentOverride: neonUserAgent,
+    userAgent: neonUserAgent,
   );
   final resultController = StreamController<core.LoginFlowV2Credentials>();
 

packages/neon_framework/lib/src/models/account.dart

@@ -40,7 +40,7 @@ class Account implements Credentials, Findable {
           loginName: username,
           password: password,
           appPassword: password,
-          userAgentOverride: userAgent,
+          userAgent: userAgent,
           cookieJar: CookieJar(),
           httpClient: httpClient,
         );

packages/nextcloud/lib/src/client.dart

@@ -1,25 +1,6 @@
 import 'package:dynamite_runtime/http_client.dart';
 import 'package:universal_io/io.dart';
 
-/// Different app types to register for
-enum AppType {
-  /// Will only receive Talk notifications
-  talk('Mozilla/5.0 (Android) Nextcloud-Talk'),
-
-  /// Will receive all notifications except Talk notifications if another Talk
-  /// app is already registered for the user
-  nextcloud('Mozilla/5.0 (Android) Nextcloud-android'),
-
-  /// Default. Same problem with notifications as the [nextcloud] type
-  unknown(null);
-
-  // ignore: public_member_api_docs
-  const AppType(this.userAgent);
-
-  // ignore: public_member_api_docs
-  final String? userAgent;
-}
-
 // ignore: public_member_api_docs
 class NextcloudClient extends DynamiteClient {
   // ignore: public_member_api_docs
@@ -29,15 +10,13 @@ class NextcloudClient extends DynamiteClient {
     String? password,
     String? appPassword,
     String? language,
-    AppType appType = AppType.unknown,
-    String? userAgentOverride,
+    String? userAgent,
     super.httpClient,
     super.cookieJar,
   }) : super(
           baseHeaders: {
             if (language != null) HttpHeaders.acceptLanguageHeader: language,
-            if ((userAgentOverride ?? appType.userAgent) != null)
-              HttpHeaders.userAgentHeader: userAgentOverride ?? appType.userAgent!,
+            if (userAgent != null) HttpHeaders.userAgentHeader: userAgent,
           },
           authentications: [
             if (appPassword != null)