Skip to content

Commit a298ebe

Browse files
committed
fix(nextcloud)!: Type WebDAV fileid as integer
Signed-off-by: provokateurin <kate@provokateurin.de>
1 parent 20fb3ab commit a298ebe

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

packages/nextcloud/generate_props.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ void main() {
2626
'comments-unread': 'int',
2727
'downloadURL': 'String',
2828
'favorite': 'int',
29-
'fileid': 'String',
29+
'fileid': 'int',
3030
'id': 'String',
3131
'owner-display-name': 'String',
3232
'owner-id': 'String',

packages/nextcloud/lib/src/webdav/file.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class WebDavFile {
3939
late final String? id = props.ocid;
4040

4141
/// The unique id for the file within the instance
42-
late final String? fileId = props.ocfileid;
42+
late final int? fileId = props.ocfileid;
4343

4444
/// Whether this is a collection resource type
4545
late final bool? isCollection = props.davresourcetype != null ? props.davresourcetype!.collection != null : null;

packages/nextcloud/lib/src/webdav/props.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ class WebDavProp with _$WebDavPropXmlSerializableMixin {
490490
namespace: namespaceOwncloud,
491491
includeIfNull: false,
492492
)
493-
final String? ocfileid;
493+
final int? ocfileid;
494494

495495
@annotation.XmlElement(
496496
name: 'id',
@@ -716,7 +716,7 @@ class WebDavOcFilterRules with _$WebDavOcFilterRulesXmlSerializableMixin {
716716
namespace: namespaceOwncloud,
717717
includeIfNull: false,
718718
)
719-
final String? ocfileid;
719+
final int? ocfileid;
720720

721721
@annotation.XmlElement(
722722
name: 'id',

packages/nextcloud/lib/src/webdav/props.g.dart

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/nextcloud/test/webdav_test.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ void main() {
227227

228228
expect(response.path, PathUri.parse('Nextcloud.png'));
229229
expect(response.id, isNotEmpty);
230-
expect(response.fileId, isNotEmpty);
230+
expect(response.fileId, greaterThan(0));
231231
expect(response.isCollection, isFalse);
232232
expect(response.mimeType, 'image/png');
233233
expect(response.etag, isNotEmpty);
@@ -262,7 +262,7 @@ void main() {
262262
expect(response.props.occommentsunread, 0);
263263
expect(response.props.ocdownloadurl, isNull);
264264
expect(response.props.ocfavorite, 0);
265-
expect(response.props.ocfileid, isNotEmpty);
265+
expect(response.props.ocfileid, greaterThan(0));
266266
expect(response.props.ocid, isNotEmpty);
267267
expect(response.props.ocownerdisplayname, 'User One');
268268
expect(response.props.ocownerid, 'user1');

0 commit comments

Comments
 (0)