-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Structure of app and app navigation entries to have #146
Comments
@jancborchardt @MorrisJobke @oparoz What do you think? |
Yep, absolutely think that’s the way to go for Gallery. 👍 Currently it’s just a weird other folder-based view, but if we make it a timeline, sort everything by date, and add these further enhancements which other photo apps also have, this is way more proper. (And then it won’t be just a "slightly different grid view".) I guess the main point is that currently the Gallery is quite outdated and doesn’t follow a lot of the design standards we developed, and has the folder-based view. So it would be (don’t shoot me :D) a good point in time to actually do it properly with Vue.js and the design guidelines. What do you think @skjnldsv @juliushaertl? There’s also some more work being done on the Maps app by @eneiluj including showing pictures on the map – so we could use that vice versa in the Gallery app too to show a map for the pictures. |
I absolutely agree with Jan that this is a good point in time to rework the gallery app. There is a lot of code in it that is basically copied from the files_sharing app and therefore utterly outdated, because we changed a lot there recently for a better user experience. For the sidebar and proper filtering, we somehow depend on nextcloud/server#5106
Not sure if we can achieve that already? Is there a dav search that we can perform to get all images in all folders?
Same as for all photos.
Not sure how the maps app looks for photos and caches the exif data, but we should probably just integrate the view here then.
A candidate once we have nextcloud/server#5106 |
Once we have the new sidebar standard, we might clone the thing into a OCA.Gallery.Sidebar with the same behaviour? It should simplify our process a lot and allow further updates and security fixes in a single location :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So should we put that high on the list for Nextcloud 18 directly? We can do some planning in this cycle and see at the Contributor Week what we need to set it up. |
sure. let's plan this |
@janis91 very cool, looks nice! :) Also seeing you are in Stuttgart, maybe come over at the next Nextcloud Contributor Week (we just had one a month ago, but doing it every ~4 months)? :) |
I will look out for it.
I understand the benefit, it's just that I did not have the opportunity to learn Vue yet ;-) |
Besides from the renewal of the gallery app, which is a good thing by the way, would it make sense for you to create own albums (you may share with others) within the gallery app? (I've asked in https://help.nextcloud.com/t/is-there-a-good-app-to-organize-photos/57742 and was told to read this issue). It can't be only me who would like this feature, or are there already solutions I didn't find so far? |
@janis91 This is super cool! It would be great if you could help to push this forward. vue is prefered as @jancborchardt mentioned :-) |
My feeling is, that this will require a lot changes, @jancborchardt does it make sense to create a new branch and start from scratch in it, or what do you think? |
Now we have a functioning maps app, thanks to @eneiluj and the others who worked on it. It would be really interesting to have an interaction between gallery and maps: if I have both apps active I'd love to have the possibility to switch from one view to the other...! I think that the request is NOT simple but it would be a terrific improvement... |
@janis91 @skjnldsv since we are doing everything in Vue now, it would absolutely make sense to do the Gallery in Vue too if we are making changes anyway. Also design-wise, things to look at are: (e.g. our variable tiling style is not really something other photo apps still use, it is either square cropped, or a square space for a photo and then shown smaller to show it in full.) |
Moved this to the repository of the all-new Photos app → https://github.com/nextcloud/photos/ @janis91 did you see that? Come and get involved :) |
The Gallery app should have a left sidebar to find and view photos similar to other photo apps on Android, iOS, Mac, Windows, Gnome, KDE, ...
Sidebar entries could be:
The text was updated successfully, but these errors were encountered: