-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clarification: Is bz2
still really recommended PHP module?
#42342
Comments
In fact, we need to understand the role of the bz2 module in nextcloud/server, and whether there are alternatives to this module. I've searched some reference materials, and currently, bz2 seems to excel in compression rates but is not very efficient in terms of performance. Additionally, it has been removed from the Linux kernel. Currently, besides its use during app installation for decompression, are there any other parts of the system that utilize this functionality? If so, it should be retained; otherwise, it might simplify the nextcloud installation package or allow those who need it to install it separately. The above is my opinion. |
See my comment here: #40889 (comment)
And I agree, if such flexibility regarding the apps archive compression algorithm is wanted, then bzip2 is probably not worth to start with. |
Upgraded to 28.0.1 and I am still getting:
|
Sure, no one has even decided whether this warning shall be removed or not.
Indeed extracting apps from app store is the only place where this API is called, from what I could find: https://github.com/nextcloud/server/blob/master/lib/private/Installer.php#L312 Unless I have overseen something (search did), and no apps on the store are compressed with bzip2, this functionality is unused. Btw, Merry Christmas to everyone celebrating it, else enjoy the season 🙂. |
Additional supplementary program locations and documentation:
Therefore, I'm contemplating whether maintaining various compression methods, even if not currently in use, serves as a reserved approach. Since in Linux systems, the prevalent file formats are mostly gz or xz, if a unified adoption of zip is considered, this feature might become obsolete. I'm not aware of the original designer's intentions; if anyone knows, perhaps it's worth seeking clarification. |
Strangely there seems to be no native PHP xz module, but only 3rd party ones outside of distro repos. |
Hi, Is this needed or not? |
This is what we are trying to clarify with this issue 😄. No final answer yet, but I am 100% sure that it is at least not really needed for anything and 99% sure that it would not even be used by Nextcloud if installed. However, if you want to install it on Debian: apt install php-bz2 and restart PHP-FPM, or Apache if |
Hi, |
Ah right, now that you mention it, it was required to add I have no time to do a PR now, but to not forget about it, and in case someone else finds time: nextcloud/documentation#11429 |
I checked through apps available for >=NC26[1]. None are in bz2 format. However one app does require bz2: https://github.com/matiasdelellis/facerecognition It's just a dependency like some other apps have other random dependencies. We don't need to be directly concerned with every app's dependencies here (for the setup checks + admin docs I mean). [1] https://nextcloudappstore.readthedocs.io/en/latest/restapi.html#api-all-releases |
Is
bz2
still really a recommended PHP module or are the docs simply out of date?#40889 added a check for it and various other modules per the current documentation.
The community Docker image does not have
bz2
. It's an easy fix if actually recommended, but it seems it may not even be used any longer: #40889 (comment)There is an open issue in the Docker repo (nextcloud/docker#2118) with over 40 upvotes to fix the warning, but it's unclear at present whether the correct solution is to:
For the record, no one really seemed to care it hasn't been in the image until this check got added to Server. :-)
It came up once a couple years ago in the Docker image for an unrelated situation, and word from the appstore then was that it's not needed any longer at least for apps. So does Server need it?
Ref:
The text was updated successfully, but these errors were encountered: