Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make the advected field type array non-const #643

Closed
timspainNERSC opened this issue Aug 19, 2024 · 0 comments · Fixed by #644
Closed

Make the advected field type array non-const #643

timspainNERSC opened this issue Aug 19, 2024 · 0 comments · Fixed by #644
Assignees
@timspainNERSC
Labels
bug Something isn't working
Milestone
3 Stand-alone model

Comments

@timspainNERSC
Copy link
Collaborator

The DynamicsKernel::fieldType map is decalred const. That's not very useful for a member variable that should be read and written.

Should also fix the deleted constructor problem for the Intel compiler.
@timspainNERSC timspainNERSC added the bug Something isn't working label Aug 19, 2024
@timspainNERSC timspainNERSC added this to the 3 Stand-alone model milestone Aug 19, 2024
@timspainNERSC timspainNERSC self-assigned this Aug 19, 2024
@timspainNERSC timspainNERSC mentioned this issue Aug 19, 2024
Merged
@timspainNERSC timspainNERSC linked a pull request Aug 20, 2024 that will close this issue
Make the advected field type array non-const #644
Merged
@timspainNERSC timspainNERSC moved this from Todo to Review required in neXtSIM_DG overview Aug 23, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in neXtSIM_DG overview Aug 23, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in neXtSIM_DG overview Aug 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@timspainNERSC timspainNERSC

Labels
bug Something isn't working
Projects
neXtSIM_DG overview
Status: Done
Milestone
3 Stand-alone model
Development

Successfully merging a pull request may close this issue.

Make the advected field type array non-const nextsimhub/nextsimdg
1 participant
@timspainNERSC