Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make DG fields in the restart file self-consistent #654

Closed
timspainNERSC opened this issue Aug 22, 2024 · 0 comments · Fixed by #665
Closed

Make DG fields in the restart file self-consistent #654

timspainNERSC opened this issue Aug 22, 2024 · 0 comments · Fixed by #665
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@timspainNERSC
Copy link
Collaborator

Currently, the thermodynamics runs after the dynamics. Since the thermodynamics changes the mean, DG0 value of prognostic fields, this can mean that the higher DG components could be such that the value of the field exceeds its physical limits. To be fully consistent the final state of fields with both DG components and geophysical limits should be immediately after the dynamics, when the limiters have just been applied.

The solution to this would be to swap the order of the dynamics and thermodynamics within the PrognosticData::update().

@timspainNERSC timspainNERSC added bug Something isn't working enhancement New feature or request labels Aug 22, 2024
@timspainNERSC timspainNERSC added this to the 3 Stand-alone model milestone Aug 22, 2024
@timspainNERSC timspainNERSC self-assigned this Aug 22, 2024
@timspainNERSC timspainNERSC changed the title Make DG fields in the restart file consistent Make DG fields in the restart file self-consistent Aug 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in neXtSIM_DG overview Aug 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in neXtSIM_DG overview Aug 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant