Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update SLACK_CHANNELS envvar #492

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Update SLACK_CHANNELS envvar #492

merged 1 commit into from
Feb 25, 2025

Conversation

joverlee521
Copy link
Contributor

Description of proposed changes

With the latest update to the new Slack APIs for uploading files, the SLACK_CHANNELS envvar is required to be a channel id instead of a channel name.¹ Rather than hard-coding the channel id in the workflows, I've made them GH Action environment variables that are shared across the Nexstrain org so they can be shared with the ncov repo.²

¹ nextstrain/ingest#47
² https://github.com/organizations/nextstrain/settings/variables/actions

Related issue(s)

Related to nextstrain/ingest#46

Checklist

  • Checks pass

With the latest update to the new Slack APIs for uploading files,
the `SLACK_CHANNELS` envvar is required to be a channel id instead
of a channel name.¹ Rather than hard-coding the channel id in the
workflows, I've made them GH Action environment variables that are
shared across the Nexstrain org so they can be shared with the
ncov repo.²

¹ <nextstrain/ingest#47>
² <https://github.com/organizations/nextstrain/settings/variables/actions>
@joverlee521
Copy link
Contributor Author

This can be merged before nextstrain/ingest#47 since the old files.upload API already accepts channel ids.

@joverlee521 joverlee521 merged commit a0d33b6 into master Feb 25, 2025
1 check passed
@joverlee521 joverlee521 deleted the update-slack-channels branch February 25, 2025 20:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants