Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

nf-core lint generates an ERROR if modules.json is missing but doesn't exit #1198

Closed
drpatelh opened this issue Jul 13, 2021 · 0 comments
Closed
Labels
bug Something isn't working linting

Comments

@drpatelh
Copy link
Member

As you can see in this CI test for the fetchngs pipeline nf-core lint prints an ERROR at the top of the screen because modules.json isn't present but doesn't generate a system exit. I am not sure there is a need for the ERROR to be printed there because this is already reported in the lint results?

Also, I think we need to allow cases where modules.json isn't present because for example, fetchngs consists entirely of local modules at the moment.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working linting
Projects
None yet
Development

No branches or pull requests

1 participant