Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check if a module is installed before running nf-core modules install #1199

Closed
drpatelh opened this issue Jul 13, 2021 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@drpatelh
Copy link
Member

Manually removing a module with rm -rf and then trying to re-install won't do anything because the module info is still in modules.json so an INFO message is printed to screen suggesting that the module is up-to-date even though it has been deleted.

Maybe a better solution is to check whether the module is installed first and re-install at the commit in modules.json if it isn't. It may be a good idea to tidy up modules.json "before" installing any modules just to make sure that we have the same modules listed in the JSON and installed locally.

$ nf-core modules install

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.0.2.dev0



? Tool name: fastqc
INFO     'nf-core/modules/fastqc' is already up to date                                                                                                     install.py:108
@drpatelh drpatelh added the bug Something isn't working label Jul 13, 2021
@chasemc
Copy link

chasemc commented Jul 13, 2021

I was going to make an issue but I think it might be related to this.

nf-core modules lint says out of date, nf-core modules install -a says everything is fine

image

@chasemc
Copy link

chasemc commented Jul 13, 2021

Yes, it is exactly what you described

@chasemc
Copy link

chasemc commented Jul 13, 2021

After downloading, running the linter results in warnings to update conda versions within module(s).
However, updating the versions results in a Local copy of module outdated warning from the linter

@ErikDanielsson
Copy link
Contributor

Closing due to the merge of #1200

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants