Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Player decoder doesn't decode fantasy_id #229

Closed
mrcaseb opened this issue Mar 23, 2021 · 0 comments · Fixed by #230
Closed

Player decoder doesn't decode fantasy_id #229

mrcaseb opened this issue Mar 23, 2021 · 0 comments · Fixed by #230

Comments

@mrcaseb
Copy link
Member

mrcaseb commented Mar 23, 2021

The internal decoder is called for fantasy_id
https://github.com/mrcaseb/nflfastR/blob/874c71b7dfcb09f1ab3f8b90e80d7e57902cf707/R/helper_decode_player_ids.R#L56

but this is missing for gsisdecoder
https://github.com/mrcaseb/nflfastR/blob/874c71b7dfcb09f1ab3f8b90e80d7e57902cf707/R/helper_decode_player_ids.R#L71
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix wpa on end game line, fix pat wp and fantasy id decoding nflverse/nflfastR
1 participant
@mrcaseb