Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate angular 17 #517

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Conversation

stefanoslig
Copy link
Contributor

@stefanoslig stefanoslig commented Nov 18, 2023

  • Angular 17
  • Standalone component
  • Lazy loaded routes
    image
  • Tiny rebranding
    image

@stefanoslig stefanoslig marked this pull request as draft November 18, 2023 20:16
@mdasberg
Copy link
Contributor

Hi @stefanoslig thanks for starting this pr. Do you need any help?

@stefanoslig
Copy link
Contributor Author

stefanoslig commented Nov 20, 2023

Hey @mdasberg . Thanks for reaching out!

What I need is a PR review when you have time. Also, I'm not sure if you agree with the tiny rebranding of the app I did in order to be closer to the new brand of Angular.

I still need to check that everything works as expected( unit, e2e tests, etc). I'll try to do this during this week

@stefanoslig stefanoslig marked this pull request as ready for review November 20, 2023 20:35
@stefanoslig
Copy link
Contributor Author

Hi @mdasberg ! I noticed that the unit tests are failing also in the master branch. I think it's better fix them in a separate branch. Could you please check my changes and merge the PR if you agree with them?

@mdasberg
Copy link
Contributor

@stefanoslig I fixed the unit tests on your branch.
Working on the integration tests atm

@stefanoslig
Copy link
Contributor Author

That's great! If you need help with this, let me know

@mdasberg mdasberg merged commit 2288d2f into ng-apimock:master Nov 30, 2023
mdasberg added a commit that referenced this pull request Nov 30, 2023
mdasberg added a commit that referenced this pull request Nov 30, 2023
github-actions bot pushed a commit that referenced this pull request Nov 30, 2023
# [3.3.0](v3.2.1...v3.3.0) (2023-11-30)

### Features

* migrate angular 17 ([#517](#517)) ([00b07c7](00b07c7))
@mdasberg
Copy link
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stefanoslig
Copy link
Contributor Author

Thanks a lot for all the work you did in the PR @mdasberg!! 💪

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants