Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide better return indicating stale scheduler #1770

Closed
gisjedi opened this issue Sep 4, 2019 · 2 comments
Closed

Provide better return indicating stale scheduler #1770

gisjedi opened this issue Sep 4, 2019 · 2 comments
Labels

Comments

@gisjedi
Copy link
Contributor

gisjedi commented Sep 4, 2019

This should not return a 204. Instead it should return something more indicative of the scheduler being stale.

Version and Environment Details

  • Scale API: 7.0.1rc4
    • Can be found at /api/v6/scheduler/status
  • Scale UI: 0.8.4
    Cluster details below are very helpful for problem resolution, but external Scale users aren't expected to provide.
  • DC/OS: kraken

Additional context

if (now() - status_timestamp).total_seconds() > StatusView.STATUS_FRESHNESS_THRESHOLD:
return Response(status=status.HTTP_204_NO_CONTENT)

@gisjedi gisjedi added the bug label Sep 4, 2019
@JohnPTobe
Copy link

Return the status but with a field warning that it's stale? Return only the stale warning with no status? I assume the problem was you tore your hair out debugging the scheduler only to figure out it was slow so something more obvious would be nice.

@cshamis
Copy link

cshamis commented Sep 7, 2019 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants