Feedback

Author: Rulox

pkg/controller/nginxingresscontroller/crds.go

@@ -39,7 +39,7 @@ func kicCRDs() ([]*v1beta1.CustomResourceDefinition, error) {
 			return nil, fmt.Errorf("failed to open the CRD manifest %v: %v", path, err)
 		}
 
-		var crd *v1beta1.CustomResourceDefinition
+		var crd v1beta1.CustomResourceDefinition
 
 		err = yaml.NewYAMLOrJSONDecoder(f, decoderBufferSize).Decode(&crd)
 
@@ -52,7 +52,7 @@ func kicCRDs() ([]*v1beta1.CustomResourceDefinition, error) {
 			return nil, fmt.Errorf("failed to close the CRD manifest %v: %v", path, err)
 		}
 
-		crds = append(crds, crd)
+		crds = append(crds, &crd)
 	}
 
 	return crds, nil

pkg/controller/nginxingresscontroller/nginxingresscontroller_controller.go

@@ -66,18 +66,18 @@ func isLocal() bool {
 func createKICCustomResourceDefinitions(mgr manager.Manager) error {
 	reqLogger := log.WithValues("Request.Namespace", "", "Request.Name", "nginxingresscontroller-controller")
 
+	if isLocal() {
+		reqLogger.Info("Skipping KIC CRDs creation; not running in a cluster")
+		return nil
+	}
+
 	// Create CRDs with a different client (apiextensions)
 	apixClient, err := apixv1beta1client.NewForConfig(mgr.GetConfig())
 	if err != nil {
 		reqLogger.Error(err, "unable to create client for CRD registration")
 		return err
 	}
 
-	if isLocal() {
-		reqLogger.Info("Skipping KIC CRDs creation; not running in a cluster")
-		return nil
-	}
-
 	crds, err := kicCRDs()
 
 	if err != nil {