Skip to content

Use assembly for WebSocket frame masking #16

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
nhooyr opened this issue Sep 24, 2018 · 4 comments
Open

Use assembly for WebSocket frame masking #16

nhooyr opened this issue Sep 24, 2018 · 4 comments
Labels
enhancement help-wanted
Milestone
v1.9.0

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Sep 24, 2018 •
edited
Loading

Will be a fun exercise for me.
@nhooyr nhooyr added complex and removed p4 labels Mar 14, 2019
@nhooyr nhooyr changed the title Use assembly for Mask function use assembly for Mask function Mar 14, 2019
@nhooyr nhooyr changed the title use assembly for Mask function Use assembly for Mask function Mar 30, 2019
@nhooyr nhooyr changed the title Use assembly for Mask function Use assembly for WebSocket frame masking Mar 30, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 30, 2019

This is definitely excessive. Don't want to spend my time here or maintain this.

@nhooyr nhooyr closed this as completed Mar 30, 2019
@wdvxdr1123
Copy link
Contributor

Hello, @nhooyr !
I have implemented simd masking with avx2&sse for amd64 and neon for arm64 which results in 4x performance improvement in amd64 and 2x erformance improvement in arm64. I can mail a PR if you're interested.

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 24, 2022

@wdvxdr1123 Please open a PR or feel free to mail me the commits. I'd be very interested! Though I can't promise I'll get to merging it soon.

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 6, 2023

Will get this in at some point after extensive automated testing against the safe version. #326

Thanks again @wdvxdr1123

@nhooyr nhooyr reopened this Mar 6, 2023
@nhooyr nhooyr added this to the v1.9.0 milestone Sep 28, 2023
@nhooyr nhooyr mentioned this issue Oct 25, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement help-wanted
Projects
None yet
Milestone
v1.9.0
Development

No branches or pull requests
2 participants
@nhooyr @wdvxdr1123