Adding server version always in the command display #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is quite important to know what version of the server is running and not only when the --version is passed.
maxxboehme
requested changes
Dec 6, 2024
| @@ -88,6 +88,15 @@ static void RunServer(const ServerConfiguration& config) | |||
| config.config_file_path.c_str()); | |||
| } | |||
|
|
|||
| std::string string_kNiDeviceGrpcBranchName(nidevice_grpc::kNiDeviceGrpcBranchName); | |||
There was a problem hiding this comment.
This is the same logic as in the --version case. Please create a static function in this file. that is then called in both places so the logic for both of these will always stay consistent.
grpc-device/source/server/core_server.cpp
Line 206 in d2f2862
|
@yardov planning to create a release branch of grpc-device 2.9.0 on the 18th. If want this change in the 2.9.0 release please make sure to continue progress on the PR. |
|
We are planning to create a release branch on the 18th, and your PR will need to be completed before then for the changes to be in effect. Do you want these changes included in this release? |
|
I'll be creating the release branch at 11:30 CST. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is quite important to know what version of the server is running and not only when the --version is passed.
What does this Pull Request accomplish?
The server when executed will always display the version running.
Why should this Pull Request be merged?
All software needs to have a way to know the version running irrespective if a tag was passed. This ensure in our customers that they know the correct version is running.
Ideally, this should be queryable by a client but that's a task for another day.
What testing has been done?
None.