Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ws: and wss: are not listed in SchemeSource #67

Open
Shamilik opened this issue Aug 3, 2022 · 1 comment · Fixed by komw/next-safe-middleware#1 · May be fixed by #70
Open

ws: and wss: are not listed in SchemeSource #67

Shamilik opened this issue Aug 3, 2022 · 1 comment · Fixed by komw/next-safe-middleware#1 · May be fixed by #70

Comments

@Shamilik
Copy link

Shamilik commented Aug 3, 2022

Screenshot 2022-08-03 at 10 48 10

Without ws:, webpack-hmr isn't working locally in Safari at least:
Screenshot 2022-08-03 at 10 51 30

@nibtime
Copy link
Owner

nibtime commented Aug 4, 2022

Hi @Shamilik

I booked a LambdaTest subscription for work today, which will make it possible for me to handle Safari-related bugs, which is otherwise kind of impossible if you don't own an Apple device :)

The blocking doesn't happen with Chrome and Firefox, they seem to resolve localhost:3000 to 'self', so this doesn't appear there. The lib automatically adds directives for next dev to work, I will extend them so it works with Safari in a PR.

Also, ws: and wss: should be allowed SchemeSource's, I will extend the typings in a PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants