Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature Request - Save my marked items #168

Open
Moshe81 opened this issue Jul 3, 2017 · 10 comments
Open

feature Request - Save my marked items #168

Moshe81 opened this issue Jul 3, 2017 · 10 comments

Comments

@Moshe81
Copy link

Moshe81 commented Jul 3, 2017

Hi,
I love Glogg.
I wish that the item I mark in blow will remain if I close the log and reopen it.
I found my self doing the same operation again and again for one log.
Thanks
Moshe

@arthurspa
Copy link

arthurspa commented Oct 18, 2017

+1
Sometimes you stops the analysis of a large log, turn off the computer to continue the next day.

It would be nice to reopen a file and have the marked items persisted, instead of having to search and mark everything again.

@variar
Copy link
Contributor

variar commented Dec 1, 2017

Currently implementing this. Should marks be restored only on first file load or on any subsequent reload?

@arthurspa
Copy link

I my opinion it would be better if the marks persist also after subsequent reloads.

@variar
Copy link
Contributor

variar commented Dec 2, 2017

Created PR. Marks are saved in session data. @arthurspa until merged you can test it in klogg dev builds:
windows zip
linux deb
mac dmg

edit: updated links to new build with fixed filters dialog

@Moshe81
Copy link
Author

Moshe81 commented Dec 2, 2017

Thanks - this is greate.
Any idea why I can not add Filters with this version ?

@variar
Copy link
Contributor

variar commented Dec 2, 2017

This is development build from master branch. I've done a lot of refactoring, and unfortunately there are only bare minimum automatic tests, so some features got broken (e.g. Quick Find). I've created an issue for this.

@variar
Copy link
Contributor

variar commented Dec 2, 2017

@Moshe81 I've identified bad commit and reverted changes for filters dialog and quickfind. New build is ready:
windows zip
linux deb
mac dmg

@arthurspa
Copy link

I did not have time to test it, but I hope it gets merged and released.

Thank you @variar for implementing this.

@nickbnf
Copy link
Owner

nickbnf commented Dec 7, 2017

Thanks @variar, will merge that. Is keeping marks on closing/re-opening glogg the use case discussed here? Or are we talking about keeping marks for each file, even if the file is closed and reopened (like vim does for marks)?

@variar
Copy link
Contributor

variar commented Dec 7, 2017

@nickbnf I've implemented saving marks only for opened files. Storing marks for all closed files forever might produce big configuration file with no way to clean it up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants