Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auto join raids #7095

Closed
1 task done
Booky06 opened this issue Oct 9, 2024 · 7 comments
Closed
1 task done

Auto join raids #7095

Booky06 opened this issue Oct 9, 2024 · 7 comments
Labels

Comments

@Booky06
Copy link

Booky06 commented Oct 9, 2024

Describe the bug

I have auto join raids turned off and for some reason it has still been sending me recently

Steps to reproduce

go to settings>channel> auto join raids option off

Expected behavior

I expect not to be sent to another channel when the streamer raids someone else

Screenshots

image

Device information

PC Edge

BetterTTV Version

7.6.7

Additional information

No response

Version Check

  • I have checked that I'm using the newest version of BetterTTV available.
@Booky06 Booky06 added the bug label Oct 9, 2024
@maxineq96
Copy link

This is also happening on firefox.

@EnderShadow
Copy link

I can confirm this is also happening for me on linux firefox

@ITerminusI
Copy link

Recently this functionality stopped working for me as well (Chrome).

@Dendraspis
Copy link

Dendraspis commented Oct 11, 2024

According to these code lines:

if (
leaveButton == null ||
['raid-cancel-button', 'raid-now-button'].includes(leaveButton.getAttribute('data-test-selector'))
) {
return;
}

...and this source:
image

...the condition should be changed to something like because there are no other attributes anymore:

    if ( leaveButton == null ) {
      return;
    }

Pull Request made: #7096

@night night closed this as completed in e710064 Oct 11, 2024
@Booky06
Copy link
Author

Booky06 commented Oct 12, 2024

issue still exists 7.6.8

@Booky06
Copy link
Author

Booky06 commented Oct 13, 2024

my apologies, the tabs that still auto raided needed refreshed, seems to be fine now

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants