Comment missing in AST when in the middle of fluent call

[ondrejmirtes]

Given this code:

<?php

declare(strict_types=1);

$objectForSetter = new ObjectForSetter();
$awesomeFeature = new AwesomeFeature();
$awesomeFeature
	->setVariable($objectForSetter->getVariable()) // @phpstan-ignore-line
	->doSmth();

There's no @phpstan-ignore-line comment in the AST.

Original issue: phpstan/phpstan#4250

[ondrejmirtes]

(Sorry for the doublepost, I got HTTP 404 from GitHub originally.)

[nikic]

This is hard to address with the current comment mechanism, which always assigns comments to the directly following node, which doesn't exist here (-> does not start a node).

I think for phpstans purposes it might be more useful to handle this not at the AST level, but to do one iteration over the tokens ($lexer->getTokens()) upfront and handle the T_COMMENT/T_DOC_COMMENT tokens. You don't care about the node it is associated with after all. I think this shouldn't be more complicated that your current code.

[ondrejmirtes]

Thank you, I'll give it a shot :)