Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include version string in the exception message #11

Conversation

asgrim
Copy link
Contributor

@asgrim asgrim commented Apr 14, 2018

Fixes #10 by adding version string.

Also added a few more tests to cover these circumstances (and converted a couple existing into using data providers too to save repetition).

@nikolaposa
Copy link
Owner

@asgrim Thanks! This just reminded me that I should move message formatting logic into named constructors for this and other exceptions as well.

@nikolaposa nikolaposa merged commit cb17876 into nikolaposa:master Apr 14, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants