Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix comparison when identifier of pre release contains both letters and numbers #20

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

dontub
Copy link

@dontub dontub commented Aug 13, 2018

Before a string containing both letters and numbers was treated wrong in the first check because ctype_alpha() returns false in that case.

@nikolaposa nikolaposa added this to the 3.1.1 milestone Aug 13, 2018
@nikolaposa nikolaposa added the bug label Aug 13, 2018
@nikolaposa nikolaposa merged commit 251205f into nikolaposa:master Aug 18, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants