Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Explicitly mark parameters as nullable #42

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

d-loki
Copy link

@d-loki d-loki commented Jan 22, 2025

This pull request addresses the deprecation warning related to implicitly marking parameters as nullable.

@nikolaposa nikolaposa self-assigned this Jan 27, 2025
@nikolaposa
Copy link
Owner

nikolaposa commented Jan 27, 2025

@d-loki Something is very off with code style in your fork. Check out the differences between:

https://github.com/nikolaposa/version/blob/master/src/Version.php

and

https://github.com/nikolaposa/version/blob/bf7c73d71a5aafcad2d3c4801bfae50cc4103a91/src/Version.php

where does that extra tab before every line comes from in your Version.php?

Screenshot 4

…and checkGenericClassInNonGenericObjectType

Replace with :
ignoreErrors:
            - identifier: missingType.generics
            - identifier: missingType.iterableValue
@d-loki
Copy link
Author

d-loki commented Jan 27, 2025

@nikolaposa I’ll check and fix the issue.
It's a configuration in my IDE. I'll start from your files and only make the necessary changes without letting my IDE update the code.

@d-loki
Copy link
Author

d-loki commented Jan 27, 2025

@nikolaposa I think it should be much better now.
Sorry for these issues, I didn’t notice that my IDE had updated the files during the commit.

@d-loki d-loki requested a review from nikolaposa January 27, 2025 13:59
@nikolaposa
Copy link
Owner

@d-loki
Copy link
Author

d-loki commented Jan 27, 2025

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants