[Pull Request] Small addon to the gringott's config #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration files, describing the type of currency checking—either the traditional method or the alternative one using key-value of material-custommodeldata.
…onfiguration files, describing the type of currency checking—either the traditional method or the alternative one using key-value of material-custommodeldata.
…onfiguration files, describing the type of currency checking—either the traditional method or the alternative one using key-value of material-custommodeldata.
…onfiguration files, describing the type of currency checking—either the traditional method or the alternative one using key-value of material-custommodeldata.
|
I think the CI system of Gringotts might be broken or something. I will merge and test it locally :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the configuration files, a new option called
custommodeldata-onlyhas been added. By default, it is set to false.This option determines the type of currency checking used in the system.
There are two types of currency checking available:
Traditional Method:
If custommodeldata-only is set to false (the default), the system will use the traditional method for currency checking.
Alternative Method using Material-CustomModelData Key-Value Pairs:
If custommodeldata-only is set to true, the system will use an alternative method for currency checking.
In this approach, the system looks at the key-value pairs of material-custommodeldata to determine currency.
This update provides flexibility in choosing the currency checking method based on your preferences or specific needs.