Don't fail validation when no RuntimesConfig #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relaxation allows projects to be read (including project.yml) when there are runtime decls in the config but the actual RuntimesConfig wasn't read. There are valid cases for this when the caller has no credential store and no API host in the environment but is just inspecting a project. It is true that invalid runtimes may be accepted in that use-case (only).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxation allows projects to be read (including
project.yml) when there are runtime declarations inproject.ymlbut the actualRuntimesConfigwasn't read. There are valid cases for this when the caller has no credential store and no API host in the environment but is just inspecting a project. For example, in the CLI,project get-metadatapasses in an emptyRuntimesConfig. It is true that invalid runtimes may be accepted in that use-case (only).