From be60cb5ea030d12e154721f973e3e8048074f0cb Mon Sep 17 00:00:00 2001 From: nioc Date: Thu, 23 Jan 2025 00:31:15 +0100 Subject: [PATCH] feat(trace): mark parent span in error --- lib/opentelemetry-node.js | 3 +++ package-lock.json | 10 +++++----- package.json | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/opentelemetry-node.js b/lib/opentelemetry-node.js index a84ccd4..c2fc0f5 100644 --- a/lib/opentelemetry-node.js +++ b/lib/opentelemetry-node.js @@ -387,6 +387,9 @@ function endSpan (msg, error, nodeDefinition) { span.recordException(error) } span.setStatus({ code: SpanStatusCode.ERROR, message: error }) + if (parent.parentSpan) { + parent.parentSpan.setStatus({ code: SpanStatusCode.ERROR }) + } } const localAttributes = parseAttribute(true, msg, nodeDefinition.z, nodeDefinition.type) if (localAttributes !== undefined) { diff --git a/package-lock.json b/package-lock.json index 0d439e1..649dacc 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "node-red-contrib-opentelemetry", - "version": "1.6.1", + "version": "1.6.2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "node-red-contrib-opentelemetry", - "version": "1.6.1", + "version": "1.6.2", "license": "AGPL-3.0-or-later", "dependencies": { "@opentelemetry/api": "^1.9.0", @@ -1818,9 +1818,9 @@ } }, "node_modules/get-tsconfig": { - "version": "4.8.1", - "resolved": "https://registry.npmjs.org/get-tsconfig/-/get-tsconfig-4.8.1.tgz", - "integrity": "sha512-k9PN+cFBmaLWtVz29SkUoqU5O0slLuHJXt/2P+tMVFT+phsSGXGkp9t3rQIqdz0e+06EHNGs3oM6ZX1s2zHxRg==", + "version": "4.10.0", + "resolved": "https://registry.npmjs.org/get-tsconfig/-/get-tsconfig-4.10.0.tgz", + "integrity": "sha512-kGzZ3LWWQcGIAmg6iWvXn0ei6WDtV26wzHRMwDSzmAbcXrTEXxHy6IehI6/4eT6VRKyMP1eF1VqwrVUmE/LR7A==", "dev": true, "peer": true, "dependencies": { diff --git a/package.json b/package.json index 8b4e849..252831f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-red-contrib-opentelemetry", - "version": "1.6.1", + "version": "1.6.2", "description": "Distributed tracing with OpenTelemetry SDK and Prometheus metrics exporter for Node-RED", "scripts": { "lint": "eslint . --fix"