From 7b26f792c8e56c1b32e6a5b3118afa853a5d7295 Mon Sep 17 00:00:00 2001
From: hirohata <43802663+hitohata@users.noreply.github.com>
Date: Wed, 20 Mar 2024 10:18:59 -0700
Subject: [PATCH] Hotfix: 327 building a type documentation has failed (#328)

* fix: incorrect type definition

* fix: added an override setting on the typedoc

* fix: tests

* chore: removed an unused import

* fix: test
---
 backend/main/src/Group/Router/ContainerRouter.ts       |  3 +--
 .../main/src/User/Controllers/FindUserController.ts    |  2 +-
 backend/main/test/Group/Router/ContainerRouter.test.ts | 10 +++++-----
 backend/main/typedoc.json                              |  5 ++++-
 4 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/backend/main/src/Group/Router/ContainerRouter.ts b/backend/main/src/Group/Router/ContainerRouter.ts
index cf9dfc3e..0ce3d646 100644
--- a/backend/main/src/Group/Router/ContainerRouter.ts
+++ b/backend/main/src/Group/Router/ContainerRouter.ts
@@ -3,7 +3,6 @@ import { honoResponseAdapter } from "src/Shared/Adapters/HonoAdapter";
 import { CreateContainerUseCase } from "src/Group/UseCases/CreateContainerUseCase/CreateContainerUseCase";
 import { CreateContainerController } from "src/Group/Controllers/CreateContainerController";
 import {
-	honoNotImplementedAdapter,
 	honoBadRequestAdapter,
 	authHeader,
 } from "src/Shared/Adapters/HonoAdapter";
@@ -268,7 +267,7 @@ const isCorrectFoodBody = (body: any): Result<IFoodDto, string> => {
 		name: body.name,
 		unit: body.unit,
 		quantity: body.quantity,
-		expiry: body.expiry ? new Date(body.expiry) : null,
+		expiry: body.expiry ? new Date(body.expiry) : undefined,
 		category: body.category,
 	});
 };
diff --git a/backend/main/src/User/Controllers/FindUserController.ts b/backend/main/src/User/Controllers/FindUserController.ts
index 53c89902..a45de543 100644
--- a/backend/main/src/User/Controllers/FindUserController.ts
+++ b/backend/main/src/User/Controllers/FindUserController.ts
@@ -27,5 +27,5 @@ export class FindUserController extends Controller<
 
 interface IFindUserData {
 	userId: string;
-	username: string;
+	name: string;
 }
diff --git a/backend/main/test/Group/Router/ContainerRouter.test.ts b/backend/main/test/Group/Router/ContainerRouter.test.ts
index 933f29c6..4967024f 100644
--- a/backend/main/test/Group/Router/ContainerRouter.test.ts
+++ b/backend/main/test/Group/Router/ContainerRouter.test.ts
@@ -22,12 +22,12 @@ describe("isCorrectFoodBody", () => {
 
 			expect(result.ok).toBeTruthy();
 
-			const { value } = result;
+			const value = result.unwrap();
 			expect(value.name).toBe(body.name);
 			expect(value.unit).toBe(body.unit);
 			expect(value.category).toBe(body.category);
 			expect(value.quantity).toBe(body.quantity);
-			expect(value.expiry.toISOString()).toEqual(body.expiry);
+			expect(value.expiry?.toISOString()).toEqual(body.expiry);
 		});
 		it("unit can be null", () => {
 			body.unit = null;
@@ -35,7 +35,7 @@ describe("isCorrectFoodBody", () => {
 			const result = isCorrectFoodBody(body);
 
 			expect(result.ok).toBeTruthy();
-			expect(result.value.unit).toBeNull();
+			expect(result.unwrap().unit).toBeNull();
 		});
 		it("quantity can be null", () => {
 			body.quantity = null;
@@ -43,7 +43,7 @@ describe("isCorrectFoodBody", () => {
 			const result = isCorrectFoodBody(body);
 
 			expect(result.ok).toBeTruthy();
-			expect(result.value.quantity).toBeNull();
+			expect(result.unwrap().quantity).toBeNull();
 		});
 		it("expiry can be null", () => {
 			body.expiry = null;
@@ -51,7 +51,7 @@ describe("isCorrectFoodBody", () => {
 			const result = isCorrectFoodBody(body);
 
 			expect(result.ok).toBeTruthy();
-			expect(result.value.expiry).toBeNull();
+			expect(result.unwrap().expiry).toBeUndefined();
 		});
 	});
 
diff --git a/backend/main/typedoc.json b/backend/main/typedoc.json
index 88f73cda..85a023c4 100644
--- a/backend/main/typedoc.json
+++ b/backend/main/typedoc.json
@@ -5,5 +5,8 @@
   "searchInComments": true,
   "plugin": ["typedoc-theme-hierarchy"],
   "tsconfig": "./tsconfig.json",
-  "name": "Nishiki Backend"
+  "name": "Nishiki Backend",
+  "compilerOptions": {
+    "noImplicitAny": false
+  }
 }
\ No newline at end of file