Skip to content

Commit d47ffb3

Browse files
author
Micah Riggan
committed
fix(node): race condition rejects
Rejecting the walletAddress import when a race condition occurs
1 parent e436459 commit d47ffb3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/bitcore-node/src/models/walletAddress.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class WalletAddressModel extends BaseModel<IWalletAddress> {
3939
const { chain, network } = wallet;
4040

4141
const unprocessedAddresses: Array<string> = [];
42-
return new Promise(async resolve => {
42+
return new Promise(async (resolve, reject) => {
4343
for (let address of addresses) {
4444
try {
4545
const updatedAddress = await this.collection.findOneAndUpdate(
@@ -61,7 +61,7 @@ export class WalletAddressModel extends BaseModel<IWalletAddress> {
6161
}
6262
} catch (err) {
6363
// Perhaps a race condition from multiple calls around the same time
64-
console.error('Likely an upsert race condition in walletAddress updates');
64+
reject('Likely an upsert race condition in walletAddress updates')
6565
}
6666
}
6767

0 commit comments

Comments
 (0)