Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

initrd-secrets test does not test that a secret actually ends up in the initrd #106

Closed
nikstur opened this issue Feb 19, 2023 · 0 comments · Fixed by #117
Closed

initrd-secrets test does not test that a secret actually ends up in the initrd #106

nikstur opened this issue Feb 19, 2023 · 0 comments · Fixed by #117
Labels
bug Something isn't working
Milestone

Comments

@nikstur
Copy link
Member

nikstur commented Feb 19, 2023

The test executes a grept that is supposed to fail if it does not find the secret in the initrd or if the contents are not as expected with boot.initrd.preDeviceCommands. However, even if this grep fails, the system comes up normally and the tests succeeds.

See: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/initrd-secrets.nix for a better way to test this.

@nikstur nikstur added the bug Something isn't working label Feb 19, 2023
@nikstur nikstur added this to the Release 1.0.0 milestone Feb 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant