Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Possible namespace collision in pep517 code #11

Open
njsmith opened this issue Jan 29, 2023 · 0 comments
Open

Possible namespace collision in pep517 code #11

njsmith opened this issue Jan 29, 2023 · 0 comments

Comments

@njsmith
Copy link
Owner

njsmith commented Jan 29, 2023

We create build directories keyed by the sdist hash. This is handy if we end up wanting both metadata and a wheel from the same sdist within the same run, because we can re-use the build directory. BUT, in principle we might end up building the same sdist for different platforms within a single run, and in that case they can't share the same directory. So we should include the platform in the directory key, or something like that.

(I guess we also re-select the build platform every time we call get_env_for_build? That seems suboptimal... probably we should end up getting the same result every time but still, maybe we should pick it once and store that somewhere to re-use.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant