Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rich text (vriendjes spacing system) #301

Open
13 tasks
AlineNap opened this issue Oct 14, 2024 · 1 comment
Open
13 tasks

Rich text (vriendjes spacing system) #301

AlineNap opened this issue Oct 14, 2024 · 1 comment

Comments

@AlineNap
Copy link
Contributor

AlineNap commented Oct 14, 2024

Omschrijving

Vriendjes spacing systeem. Kunnen wij dit ook toepassen op mijn aansluitingen?

Zie utrecht: https://nl-design-system.github.io/utrecht/storybook/?path=/story/css_css-rich-text--default

Definition of ready

  • Code check op community component gedaan door lux devs
  • Stijling check op community component gedaan door Aline
  • Plan voor missende features of bugs van het community component beschreven in het ticket
  • Component tokens zijn beschikbaar
  • Ticket doorgenomen met Vlad & Mark

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken (zie ook Testing components)
  • Visual regression test (door LUX)

Links

  • Component:
  • Figma:
  • Community component:
    • CSS:
    • React:
    • Code:
@AlineNap AlineNap converted this from a draft issue Oct 14, 2024
@AlineNap
Copy link
Contributor Author

AlineNap commented Nov 4, 2024

Stijling review

Hier alvast de tokens met dezelfde waarde als bij RHC om mee te spelen.

{
  "utrecht": {
    "rich-text": {
      "stranger": {
        "margin-block-end": {
          "value": "{lux.space.400}",
          "type": "spacing"
        }
      },
      "acquaintance": {
        "margin-block-end": {
          "value": "{lux.space.200}",
          "type": "spacing"
        }
      },
      "friend": {
        "margin-block-end": {
          "value": "{lux.space.100}",
          "type": "spacing"
        }
      },
      "best-friend": {
        "margin-block-end": {
          "value": "{lux.space.50}",
          "type": "spacing"
        }
      },
      "confidant": {
        "margin-block-end": {
          "value": "{lux.space.0}",
          "type": "spacing"
        }
      }
    }
  }
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant