Skip to content
This repository has been archived by the owner on Feb 21, 2020. It is now read-only.

Sample app: browser context creation and disposal don't match #8

Open
ato opened this issue Jan 25, 2017 · 0 comments
Open

Sample app: browser context creation and disposal don't match #8

ato opened this issue Jan 25, 2017 · 0 comments
Labels
bug

Comments

@ato
Copy link
Member

ato commented Jan 25, 2017

#6 moved context creation into init() but it's still disposed on every single request in the finally block in render(). Not sure why we're not seeing issues from that.

I think we should be creating a new context each time so that we don't preserve cookies etc across requests.
@ato ato changed the title Browser context creation and disposal doesn't match Browser context creation and disposal don't match Jan 25, 2017
@ato ato changed the title Browser context creation and disposal don't match Sample app: browser context creation and disposal don't match Jan 25, 2017
@ato ato added the bug label Jan 25, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ato