Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor: Consider removing usage of setTimeout #894

Open
GrosSacASac opened this issue Oct 9, 2022 · 0 comments
Open

Refactor: Consider removing usage of setTimeout #894

GrosSacASac opened this issue Oct 9, 2022 · 0 comments
Labels
Area: files Things related to handling files, names, etc. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.

Comments

@GrosSacASac
Copy link
Contributor

What problem are you trying to solve?

a11190f

Maybe do not use setTimeout

Do you have a new or modified API suggestion to solve the problem?

Use on('close' callback.

Other

Not sure, this is race condition specific, so traditional unit tests don't work
@GrosSacASac GrosSacASac added Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR. Area: files Things related to handling files, names, etc. labels Oct 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Area: files Things related to handling files, names, etc. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GrosSacASac