Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Segfault if stopProfiling called when not profiling #102

Open
cxreg opened this issue Jan 27, 2017 · 0 comments
Open

Segfault if stopProfiling called when not profiling #102

cxreg opened this issue Jan 27, 2017 · 0 comments

Comments

@cxreg
Copy link

cxreg commented Jan 27, 2017

Obviously this is not something a user should do but it should throw an exception instead of segfaulting.

The problem appears to be at https://github.com/node-inspector/v8-profiler/blob/master/src/cpu_profiler.cc#L54 where profile will be NULL if v8 didn't think a profile was running when asked to stop. This then manifests as a null pointer dereference at https://github.com/node-inspector/v8-profiler/blob/master/src/cpu_profile.cc#L65
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cxreg