Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backporting to v6.x-staging #216

Closed
gibfahn opened this issue May 15, 2017 · 2 comments
Closed

Backporting to v6.x-staging #216

gibfahn opened this issue May 15, 2017 · 2 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented May 15, 2017

Comment if you start or stop backporting.

Working from this gist

List generated from this command:
branch-diff v6.x-staging upstream/v7.x --exclude-label semver-major,semver-minor,dont-land-on-v6.x,backport-requested-v6.x,backported-to-v6.x,baking-for-lts --reverse --filter-release Raw

Labels information in nodejs/node#12431

Commits to backport:

Ticked means looked at

  • [f5a702e763] - stream: Fixes missing 'unpipe' event (Christopher Luke) #11876 => v7.x backport cherry-picks cleanly, PR depends on test: add common.mustNotCall() node#11152
  • [592db37e2f] - test: move test to sequential for reliability (Rich Trott) #12704 => should land
  • [c2c62874d4] - doc: fix formatting of TOC (Refael Ackermann) #12731 => should land
  • [7af2e7940c] - test: fix permanent deoptimizations (Brian White) #12456 => asked on PR
  • [cd54208463] - process: cast promise rejection reason to string (Cameron Little) #11640 => asked on PR
    • [d78adccc08] - test: support multiple warnings in checkWarning (Cameron Little) #11640
  • [f60a2e9527] - doc: fixup the collaborators list (Alexey Orlenko) #12750 => landed
  • [819c131f58] - test: improve test-tcp-wrap-listen (alohaglenn) #12599 => conflicts, could be backported
  • [90bba9fd3e] - test,doc: document crashOnUnhandledRejection() (Anna Henningsen) #12699 => dont land, docs a non-existent function
  • [224fd3af97] - benchmark: terminate child process on Windows (Rich Trott) #12658
  • [360efe48bc] - doc: fix examples in repl.md (Vse Mozhet Byt) #12684
  • [395380a136] - doc: add Added-in metadata for WHATWG URL (Timothy Gu) #12683
    • [fc96d1a573] - doc: document url.domainTo* methods separately (Timothy Gu) #12683
  • [79dff99428] - test: remove eslint comments from test-util.js (cjihrig) #12669
  • [3e9e6afd8a] - test: use common.mustCall in test-https-strict (weewey) #12668
  • [75e053be39] - test: cleanup test-util-inherits.js (RobotMermaid) #12602
  • [212475b451] - build: use do_not_edit variable where possible (Ruslan Bekenev) #12610
  • [745dea994e] - test: use common.js to check platform (Ruslan Bekenev) #12629
  • [d154aafe18] - deps: remove **/node_modules/form-data/README.md (Jeremiah Senkpiel) #12643
  • [8e6d4402a0] - test: improve test-process-kill-pid (alohaglenn) #12588
  • [660e58c7eb] - test: improved type checking with regex (coreybeaumont) #12591
  • [e36a256c6b] - test: cleanup test-fs-watch.js (RobotMermaid) #12595
  • [d15b1c4446] - test: add mustCall in test-timers-clearImmediate (Zahidul Islam) #12598
  • [46a7c297d3] - tools: use no-useless-concat ESLint rule (Vse Mozhet Byt) #12613
  • [45facc8822] - doc: fix an unclear wording in readline.md (Vse Mozhet Byt) #12605
  • [da01ff7507] - src: remove invalid comment (cjihrig) #12645
  • [1316c77b79] - doc: improve randomfill and fix broken link (Sakthipriyan Vairamani (thefourtheye)) #12541
  • [744ed9477b] - src: expose V8's IsNativeError() in util bindings (cjihrig) #12546
  • [51eafe8f3c] - meta: update authors list (Aashil Patel) #11533
  • [258eeaa519] - tools: enable no-useless-return eslint rule (cjihrig) #12577
  • [313b205834] - doc: prepare js code for eslint-plugin-markdown (Vse Mozhet Byt) #12563
  • [cbdf9a90d1] - lib: fix typo in comments in module.js (WORMSS) #12528
  • [989d344ba9] - test: use block scoped variable names (Neehar Venugopal) #12544
  • [b82e0769fe] - test: dynamic port in cluster eaddrinuse (Sebastian Plesciuc) #12547
  • [8ae5afe2d2] - test: dynamic port in cluster ipc throw (Sebastian Plesciuc) #12571
  • [539ffaef83] - url: improve descriptiveness of identifier (Rich Trott) #12579
  • [80ceb04644] - test: replace assertion error check with regex (thelady) #12603
  • [2021ea1c12] - test: refactored context type err message to regex (Muhsin Abdul-Musawwir) #12596
  • [1a4bf431fc] - test: improve test-process-chdir (vperezma) #12589
  • [14e93f6369] - test: dynamic port in parallel cluster tests (Sebastian Plesciuc) #12584
  • [d10eb83325] - test: remove flaky designation for test on AIX (Rich Trott) #12564
  • [200e899cc4] - tools: add root: true in main .eslintrc.yaml (Vse Mozhet Byt) #12570
  • [b52f77df43] - doc: fix typo in doc/api/process.md (morrme) #12612
  • [08951a1307] - src: replace IsConstructCalls with lambda (Daniel Bevenius) #12533
  • [f0b5afe721] - test: dynamic port in cluster worker dgram (Sebastian Plesciuc) #12487
  • [47b39928d5] - doc: make commit guidelines easier to reference (Benjamin Fleischer) #11732
  • [661ff6dae3] - test: move test-debugger-repeat-last to sequential (kumarrishav) #12470
  • [184941ef0b] - src: remove TODO about uv errno removal (Daniel Bevenius) #12536
  • [4276c213f2] - doc: add suggestion to use --3way (Michael Dawson) #12510
  • [0fb69de277] - test: use duplex streams in duplex stream test (cjihrig) #12514
  • [78ac637fe2] - build: fix case in lib names (Refael Ackermann) #12522
  • [f84a5e19b7] - test: use JSON.stringify to trigger stack overflow (Yang Guo) #12481
  • [e77f1e2177] - v8: fix stack overflow in recursive method (Ben Noordhuis) #12460
  • [96b2faa79b] - test: fix parallel/test-setproctitle.js on alpine (David Cai) #12413
  • [e3ccc3109c] - test: set benchmark-child-process flaky on windows (Rich Trott) #12561
  • [3703fc6bbe] - doc: update link to Code of Conduct (Alex Autem) #12552
  • [434873d24b] - doc: fix typo in fs.watch() description (Ivo von Putzer Reibegg) #12550
  • [eb78722922] - doc: add lucamaraschi to collaborators (Luca Maraschi) #12538
  • [b09bf51cdf] - repl: support hidden history file on Windows (Bartosz Sosnowski) #12207
  • [7d87edc1ba] - benchmark: add benchmark for string concatenations (Vse Mozhet Byt) #12455
  • [08ba9d437c] - benchmark: fix CLI arguments check in common.js (Vse Mozhet Byt) #12429
  • [37261319d6] - test: minimize time for child_process benchmark (Rich Trott) #12518
  • [eac0d70429] - test: console.log removed from test-net-localport (Faiz Halde) #12483
  • [a213320745] - test: dynamic port in cluster worker disconnect (Sebastian Plesciuc) #12457
  • [ddc35282c0] - test: remove uses of common.PORT in test-tls-client tests (Ahmed Taj elsir) #12461
  • [13441eb1e1] - tools: add table parsing capability to the doctool (Roman Reiss) #9532
  • [9250f02d12] - doc: clarify the callback arguments of dns.resolve (Roman Reiss) #9532
  • [f48d06c042] - test: dynamic port in cluster worker send (Sebastian Plesciuc) #12472
  • [a75fbe024a] - test: increase coverage for buffer.js (Rich Trott) #12476
  • [38278db9c7] - doc: unify spaces in a querystring.md code example (Vse Mozhet Byt) #12465
  • [e919941a21] - test: add test for child_process benchmark (Joyee Cheung) #12326
  • [8e3d54aca5] - test: complete coverage of lib/child_process.js (cjihrig) #12367
  • [922c457365] - test: buffer should always be stringified (Luca Maraschi) #12355
  • [db585c9b4d] - crypto: update root certificates (Ben Noordhuis) #12402
  • [3c8e366c2a] - tools: update certdata.txt (Ben Noordhuis) #12402
  • [6003958872] - tools: add compile_commands.json gyp generator (Ben Noordhuis) #12450
  • [83a28eeff8] - tools: update gyp to eb296f6 (Refael Ackermann) #12450
  • [3fc25dce82] - doc: run tests before landing changes (Rich Trott) #12416
  • [af0067cc5e] - doc: avoid colloquialism (Rich Trott) #12417
  • [611c23cca6] - test: use dynamic port in test-cluster-bind-twice (Rich Trott) #12418
  • [a7e13e012d] - test: remove common.PORT from test-cluster*.js (Tarun Batra) #12441
  • [d0ba631efa] - doc: fix encoding string in buffer example (MapleUncle) #12482
  • [a34cccceaa] - test: use dynamic port in 3 test-cluster-worker tests (Sebastian Plesciuc) #12443
  • [3d8878c592] - doc: correct git fix whitespace command (Mateusz Konieczny) #12445
  • [320b80b792] - test: add --use-bundled-ca to tls-cnnic-whitelist (Daniel Bevenius) #12394
  • [8ac387be3e] - net: refactor onSlaveClose in Server.close (Claudio Rodriguez) #12334
  • [440f4d4eef] - Revert "benchmark: fix CLI arguments check in common.js" (James M Snell) #12474
  • [b7aeed7a7e] - benchmark: improve cli error message (Brian White) #12421
  • [e6be4b951a] - build: make linter targets silent (Sakthipriyan Vairamani (thefourtheye)) #12423
  • [917534d541] - benchmark: fix CLI arguments check in common.js (Vse Mozhet Byt) #12429
  • [077187e9a8] - doc: s/origin/upstream/ collaborator guide (Anna Henningsen) #12436
  • [3c59d87164] - test: add crypto check to crypto-lazy-transform (Daniel Bevenius) #12424
  • [5a2d358f2e] - doc: remove inspector experimental warning (cjihrig) #12408
  • [2e3813f730] - meta: move the Code of Conduct to TSC repository (James M Snell) #12147
  • [320e72b32d] - doc: add missing ) in CONTRIBUTING.md (Mateusz Konieczny) #12444
  • [0f290f2414] - test: enable setuid/setgid test (Rich Trott) #12403
  • [4570d9853c] - doc: add guide for backporting prs (Evan Lucas) #11099
  • [d7d1e923ad] - doc: update link for landing PRs (Rich Trott) #12415
  • [4a19062294] - test: replace [].join() with ''.repeat() (Jackson Tian) #12305
  • [4ce58bd56a] - doc: add DavidCai1993 to collaborators (David Cai) #12435
  • [984232cc2a] - doc: fix typo in streams.md (John Paul Bamberg) #12428
  • [060b63e91f] - doc: add jkrems to collaborators (Jan Krems) #12427
  • [5ed9ed3317] - test: remove common.PORT from test-cluster-basic (Rich Trott) #12377
  • [e4b2f61fb5] - buffer: use slightly faster NaN check (Brian White) #12286
  • [6a45be2fa6] - doc: path functions ignore trailing slashes (Tobias Nießen) #12181
  • [0661fdf781] - test: add test-benchmark-crypto (Rich Trott) #12347
  • [6998e8026b] - os,vm: fix segfaults and CHECK failure (Tobias Nießen) #12371
  • [92e239d001] - doc: add info about serializable types (Shubheksha Jalan) #12313
  • [5c57feaa27] - doc: fix formatting in onboarding-extras (Rich Trott) #12350
  • [092c7239ee] - test: add hasCrypto check to test-debug-usage (Daniel Bevenius) #12357
  • [ebeb6c0a26] - buffer: optimize write() (Brian White) #12361
  • [4d9e6718f8] - build: run cpplint even if jslint failed (Ruslan Bekenev) #12276
  • [e2d66ab809] - doc: response.write ignores body in some cases (Ruslan Bekenev) #12314
  • [d1e1832398] - doc: add AnnaMag to collaborators (AnnaMag) #12414
  • [8ac8e50a58] - crypto: make LazyTransform compabile with Streams1 (Matteo Collina) #12380
  • [d58fa7873f] - benchmark,windows: TCP.readStart() meaningful only after completion (Refael Ackermann) #12258
  • [f3db9a6437] - doc: limit lines to 80 cols in internal README (Evan Lucas) #12358
  • [aff0cfc2d7] - test: improve punycode coverage to check surrogate pair (Nao YONASHIRO) #12354
  • [ed130168ed] - doc: add single arg scenario for util.format (Tarun Batra) #12374
@gibfahn gibfahn changed the title Backporting Backporting to v6.x-staging May 15, 2017
@gibfahn
Copy link
Member Author

gibfahn commented May 16, 2017

@MylesBorins there were a couple of commits that I wasn't sure about, please review:

/Users/gib/wrk/com/DANGER/node/test/parallel/test-fs-symlink.js
  17:7  error  Unnecessary return statement  no-useless-return

✖ 1 problem (1 error, 0 warnings)

@gibfahn
Copy link
Member Author

gibfahn commented May 16, 2017

This is done.

@gibfahn gibfahn closed this as completed May 16, 2017
@gibfahn gibfahn mentioned this issue Jun 15, 2017
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant