Skip to content

Use ref/unref terminology instead of addref/release #188

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jasongin opened this issue Mar 22, 2017 · 1 comment
Closed

Use ref/unref terminology instead of addref/release #188

jasongin opened this issue Mar 22, 2017 · 1 comment
Assignees
@boingoing

Comments

@jasongin
Copy link
Member

Consider renaming:

  • napi_reference_addref()
  • napi_reference_release()

To:

  • napi_reference_ref()
  • napi_reference_unref()

To be consistent with the "Ref/Unref" terminology used throughout Node.js.

See nodejs/node#11975 (comment)
@boingoing boingoing mentioned this issue Mar 23, 2017
Merged
@boingoing
Copy link

Fixed by #193

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@boingoing boingoing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boingoing @jasongin