-
-
Notifications
You must be signed in to change notification settings - Fork 169
Install docker on subset of test machines #301
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
quick question: how do we then automate installing alpine/similar on top of docker? is it part of the same build script? |
@jbergstroem distribution installation is always a part of Dockerfiles. No ansible scripts needed. Here's a pull request that passes locally, but fails due to resource constraints: |
The problematic part is how to publish binaries from docker to https://nodejs.org/dist/ archives. |
So there are 4 dockerfiles needed:
1 & 2 could be the same dockerfile, but with a different build context (different source trees). |
Number 4 in that list is this: nodejs/docker-node#156 Number 3 is what this issue is for. Number 1 & 2 should be handled in #75 |
Number 3 (this issue) is presumably being fixed by #437 |
I think this issue can be closed as the motivation was to get alpine runs into the ci and it looks like they are there. |
As discussed in latest build WG meeting, in order to be able to run tests on certains OS's (like Alpine - see #75) we need docker to be installed on a subset of the test machines.
We should likely start by adding it as a dependency in Ansible for our ubuntu 14 machines which are fairly recent and which run docker well.
The text was updated successfully, but these errors were encountered: