Skip to content

bot failed to bucket many labels into lib / src #137

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Fishrock123 opened this issue Apr 13, 2017 · 1 comment
Closed

bot failed to bucket many labels into lib / src #137

Fishrock123 opened this issue Apr 13, 2017 · 1 comment
Labels
in progress

Comments

@Fishrock123
Copy link
Contributor

See nodejs/node#12366

cc @mscdex
@phillipj phillipj mentioned this issue May 6, 2017
Merged
@phillipj
Copy link
Member

phillipj commented May 6, 2017 •
edited
Loading

This is because lib / src label bucket/limiter is exclusively done for files in lib/. Most interesting code is in matchSubSystemsByRegex() and hasJsSubsystemChanges().

I take it that's wrong, so I started on a fix: #141

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fishrock123 @phillipj