Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: support language standard keys in msvs_settings #252

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: support language standard keys in msvs_settings #252

merged 1 commit into from
May 8, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 7, 2024

@targos targos mentioned this pull request May 7, 2024
Merged
@lemire
Copy link
Member

lemire commented May 7, 2024

Let us clean the Windows build settings, making them less hackish. :-)

StefanStojanovic
StefanStojanovic approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit 322f6d5 into nodejs:main May 8, 2024
25 checks passed
@targos targos deleted the language-standard branch May 8, 2024 04:53
@github-actions github-actions bot mentioned this pull request May 8, 2024
Merged
@StefanStojanovic StefanStojanovic mentioned this pull request May 13, 2024
Open
13 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lemire lemire lemire approved these changes

@cclauss cclauss cclauss approved these changes

@legendecas legendecas legendecas approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @lemire @cclauss @legendecas @StefanStojanovic