Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: mark external memory and version APIs as basic #1597

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

legendecas
Copy link
Member

Fixes #1594

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.40%. Comparing base (ae2c23e) to head (7ab86a2).

Files with missing lines Patch % Lines
napi-inl.h 50.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
+ Coverage   64.42%   66.40%   +1.97%     
==========================================
  Files           3        3              
  Lines        2010     2143     +133     
  Branches      699      702       +3     
==========================================
+ Hits         1295     1423     +128     
- Misses        147      150       +3     
- Partials      568      570       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legendecas
Copy link
Member Author

Thanks for pointing it out, updated!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit 78da4fa into nodejs:main Oct 25, 2024
54 checks passed
@legendecas legendecas deleted the basic-env-apis branch October 25, 2024 19:07
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Should AdjustExternalMemory take a BasicEnv?
4 participants