feat(git-v8): preserve original author when backporting #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM for clean cherry-picks (I was reluctant to do it when we had the AUTHORS file). What about backports with conflicts? I feel like we should add a |
|
@targos LGTY? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels wrong to me to take credit when backporting a V8 commit. I see a reason for not cherry-picking the actual commit instead of creating a new one, so this PR is doing that (with a flag to roll back to the previous behavior).
I'm also adding the
-Sflag for those who want to selectively sign commits.