-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[QUESTION] Engines of next major version? #2753
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@targos any thoughts on this? 👀 |
Additionally/separately/related, can v9 lower its bottom threshold to v12.13? That would address npm/cli#5049 (comment) without the npm team having to do a dozen backports. |
Given https://github.com/nodejs/release#release-schedule working to preserve unsupported versions seems like busywork that is encouraging the community to be lazy about performing upgrades that may increase reliability, performance, and security. |
@cclauss the support for a version is irrelevant; there's still a semver violation that's happened, and that needs to be fixed - if node-gyp won't drop its arbitrarily raised support threshold, then npm would be forced to backport almost a dozen packages (thus downgrading them to node-gyp 8). The difference in effort seems pretty clear cut to me ¯\_(ツ)_/¯ |
npm/statusboard#519 says that npm is making a breaking change in their next major upgrade. That sounds like a good idea to me. My comment is that node-gyp should make a similar breaking change in its next major release to be in alignment with https://github.com/nodejs/release#release-schedule Making such breaking changes does not mean that dozens of tools need to be backported. It may however mean that dozens of tools need to be upgraded. |
That's totally fine! My comment is just about a patch for the convenience of me, and the npm team, in v9 to lower the threshold. In v10 you can drop whatever you want :-) |
I'm not really involved in |
#2601 was made for npm 8 so that it could have a much more deduplicated node_modules tree. This request will do the same for npm 9. Since this issue was created npm 9 has been tagged as |
my apologies for the ping @targos - I saw you were someone with a high number of commits and I know you 😅 |
I opened two PRs to address this issue:
|
In
npm/cli
we depend onnode-gyp
and would like to make sure the next major version is compatible withnpm
when it comes toengines.node
.Previously,
npm
used^12.13
as the lower base andnode-gyp
used^12.22
which caused the following issue: npm/cli#4987npm@9
was recently released (but is not yet taggedlatest
) with the engines set to^14.17.0 || ^16.13.0 || >=18.0.0
(see our reasoning here npm/statusboard#519).Are there plans for a major release soon? If so, has
engines.node
support been discussed?The text was updated successfully, but these errors were encountered: