Skip to content

Commit 031a130

Browse files
targosnodejs-github-bot
authored andcommitted
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC. PR-URL: nodejs/node#47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent f8d295e commit 031a130

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.0',
40+
'v8_embedder_string': '-node.1',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/src/base/macros.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -442,9 +442,9 @@ bool is_inbounds(float_t v) {
442442
// Setup for Windows shared library export.
443443
#define V8_EXPORT_ENUM
444444
#ifdef BUILDING_V8_SHARED_PRIVATE
445-
#define V8_EXPORT_PRIVATE __declspec(dllexport)
445+
#define V8_EXPORT_PRIVATE
446446
#elif USING_V8_SHARED_PRIVATE
447-
#define V8_EXPORT_PRIVATE __declspec(dllimport)
447+
#define V8_EXPORT_PRIVATE
448448
#else
449449
#define V8_EXPORT_PRIVATE
450450
#endif // BUILDING_V8_SHARED
@@ -454,8 +454,8 @@ bool is_inbounds(float_t v) {
454454
// Setup for Linux shared library export.
455455
#if V8_HAS_ATTRIBUTE_VISIBILITY
456456
#ifdef BUILDING_V8_SHARED_PRIVATE
457-
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
458-
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
457+
#define V8_EXPORT_PRIVATE
458+
#define V8_EXPORT_ENUM
459459
#else
460460
#define V8_EXPORT_PRIVATE
461461
#define V8_EXPORT_ENUM

0 commit comments

Comments
 (0)