Skip to content

Commit 3fa8644

Browse files
targosnodejs-github-bot
authored andcommitted
deps: make V8 compatible with older glibc
Remove call to `memfd_create`. The function that references it is only used for V8 testing. Refs: #220
1 parent 3128fe8 commit 3fa8644

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.6',
39+
'v8_embedder_string': '-node.7',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/base/platform/platform-posix.cc

-8
Original file line numberDiff line numberDiff line change
@@ -576,15 +576,7 @@ void OS::FreeAddressSpaceReservation(AddressSpaceReservation reservation) {
576576
#if !defined(V8_OS_MACOS)
577577
// static
578578
PlatformSharedMemoryHandle OS::CreateSharedMemoryHandleForTesting(size_t size) {
579-
#if V8_OS_LINUX && !V8_OS_ANDROID
580-
const char* name = "V8MemFDForTesting";
581-
int fd = memfd_create(name, MFD_CLOEXEC);
582-
if (fd == -1) return kInvalidSharedMemoryHandle;
583-
CHECK_EQ(0, ftruncate(fd, size));
584-
return SharedMemoryHandleFromFileDescriptor(fd);
585-
#else
586579
return kInvalidSharedMemoryHandle;
587-
#endif
588580
}
589581

590582
// static

0 commit comments

Comments
 (0)