Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

v8::WrapperDescriptor is deprecated #283

Closed
targos opened this issue May 15, 2024 · 4 comments
Closed

v8::WrapperDescriptor is deprecated #283

targos opened this issue May 15, 2024 · 4 comments

Comments

@targos
Copy link
Member

targos commented May 15, 2024

@joyeecheung
@joyeecheung
Copy link
Member

As noted in nodejs/node#52295 (comment) we need to wait for the 12.5 update before we can migrate to the new API

@targos
Copy link
Member Author

targos commented May 15, 2024 •
edited
Loading

This is the canary repo. The goal is to prepare patches in advance so when we upgrade V8, the build is already fixed.
You can either directly push a fix to nodejs/node#canary-base or share a patch here.

@joyeecheung
Copy link
Member

Oh cool, didn't realize it. I'll prepare one next week.

@legendecas legendecas mentioned this issue May 17, 2024
Closed
This was referenced May 20, 2024
Closed
Closed
@targos
Copy link
Member Author

targos commented Jun 4, 2024 •
edited
Loading

Fixed by 30329d0 (nodejs/node#53086)

@targos targos closed this as completed Jun 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @joyeecheung