Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Upcoming change to build config #39

Closed
hashseed opened this issue Mar 6, 2018 · 5 comments
Closed

Upcoming change to build config #39

hashseed opened this issue Mar 6, 2018 · 5 comments
Assignees
@refack

Comments

@hashseed
Copy link
Member

hashseed commented Mar 6, 2018

This upcoming change will change the run_mksnapshot build target to produce one more file. The background is that we want to make builtin code objects isolate-independent and move them off V8's heap and embed them in the binary instead.

I don't think this will cause breakages in the short term, since this configuration is gated by a build flag. It makes sense to look out for this and maybe port to gyp though.
@targos
Copy link
Member

targos commented Mar 13, 2018

For reference, commits that landed:
v8/v8@e6476f8
v8/v8@f45eca7

@targos
Copy link
Member

targos commented Mar 13, 2018

Also: v8/v8@abcc28c

@refack refack self-assigned this Sep 16, 2018
@refack
Copy link

refack commented Sep 16, 2018

@targos this still hasn't been done, right? I'll fold this into https://github.com/refack/node/tree/gyp-v8-embedded-builtins

@targos
Copy link
Member

targos commented Sep 17, 2018 •
edited
Loading

This hasn't been done AFAIK

This was referenced Sep 17, 2018
Closed
Closed
@targos
Copy link
Member

targos commented Oct 5, 2018

Done in nodejs/node#22920

@targos targos closed this as completed Oct 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@refack refack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@refack @hashseed @targos